Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

dev: Make HasherT methods accept iterator #1621

Closed
wants to merge 14 commits into from
Closed

dev: Make HasherT methods accept iterator #1621

wants to merge 14 commits into from

Conversation

fishseabowl
Copy link
Contributor

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Feature

What is the current behavior?

Resolves: #1613

What is the new behavior?

  1. HasherT methods accept iterator
  2. Add a default impl for compute_hash_on_wrappers

Does this introduce a breaking change?

Other information

tdelabro
tdelabro suggested changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@tdelabro tdelabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for xJonathanLEI/starknet-rs#594
before merging this one

crates/pallets/starknet/src/tests/utils.rs Outdated Show resolved Hide resolved
crates/primitives/hashers/src/lib.rs Outdated Show resolved Hide resolved
@tdelabro
Copy link
Collaborator

tdelabro commented Jun 3, 2024

Okay, mb I didn't remember we were internally calling starknet-rs, which takes an &[FieldElement].

For now let's just keep the default impl part of the PR and revert the IntoIterator one.
Once this is merged xJonathanLEI/starknet-rs#594, we will add it

@fishseabowl
Copy link
Contributor Author

Okay, mb I didn't remember we were internally calling starknet-rs, which takes an &[FieldElement].

For now let's just keep the default impl part of the PR and revert the IntoIterator one. Once this is merged xJonathanLEI/starknet-rs#594, we will add it

Sure. Thank you for your review.

@fishseabowl fishseabowl requested a review from tdelabro June 4, 2024 22:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2024

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Jul 7, 2024
@tdelabro
Copy link
Collaborator

tdelabro commented Aug 2, 2024

repository archived in favor of https://github.com/madara-alliance/madara

@tdelabro tdelabro closed this Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tdelabro tdelabro Awaiting requested review from tdelabro

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dev: make HasherT methods accept iterator rather than &[Felt] as argument
2 participants
@fishseabowl @tdelabro